Janusz Marcinkiewicz

Results 33 comments of Janusz Marcinkiewicz

> Is the idea that .Before shouldn't be run when you're doing tab completion? Hm, I think it all comes down to this. Yes. And I think the `.After` as...

I would say yes. As provided in the example, the default behaviour of returning an error in `.Before` breaks the `.BashComplete` output. So then what is the point of returning...

I could write a fix for that but I would need to know the decision: if we want to do it and if the approach of "skipping `.Before` and `.After`...

To support my arguments here is my use-case: I use CLI to communicate with some server via API. To make sure that user correctly connected to the server I do...

> Good call there. As of #1117 that is no longer the case. Sounds awesome :) > My guess to both of those are "no" and "no", and we'd be...

@meatballhat it still reproduces on latest release.

Yup, that's sounds correct.

@dearchap from what I see the PR targets v2. But the issue is raised for v1, which I currently use.

@dteplits I think it would be worth specifying the release notes. After all you are changing the user interface.