Violet Hynes

Results 83 comments of Violet Hynes

I realize I might have gotten my wires crossed here -- are you using Vault Agent's templating to retrieve the PKI cert? You linked the templating docs so I might...

Hey there! Apologies, it does seem like I got a bit mixed up. The behaviour you're experiencing is expected behaviour. The root of why is this doesn't work is that...

Thanks for this! I chatted with @divyaac and she's approved it, I resolved the merge conflicts (I think they were mostly my fault!) and I'll try and get this merged...

@tsaarni it looks like there are merge conflicts with main -- sorry for jumping the gun with my last comment. If you could get them fixed and tag me when...

Hey @crazybolillo ! I'm interested in getting this merged. I just tested this a little locally and it doesn't look like it breaks anything. Before we can do that, it...

Hi there @thomashargrove ! Sorry that this has lingered so long. I did some research and it looks like this approach makes sense. I'm not the biggest dynamodb expert but...

Thanks again, and thanks for your patience in awaiting a review for this :)

Hey there @unRob ! I'm really very sorry this one has waited so long, but I'm pretty eager to get it merged in as long as you are. There's just...

Oh, one last thing, we would require a changelog for this. I'm happy to do it myself if you don't want to fiddle, but it'd be a file in the...

Hi there @clwluvw ! Just one little thing before we get this merged: the linter check failed with the following: `command/agentproxyshared/sink/file/file_sink_test.go:139:1: Test TestFileSinkMode_Ownership is missing a go doc` Could you...