vault icon indicating copy to clipboard operation
vault copied to clipboard

agent: allow changing file ownership in file sink

Open clwluvw opened this issue 1 year ago • 3 comments

Allow changing the ownership of the token file in file sink.

clwluvw avatar May 18 '24 18:05 clwluvw

Hi there @clwluvw ! Just one little thing before we get this merged:

the linter check failed with the following: command/agentproxyshared/sink/file/file_sink_test.go:139:1: Test TestFileSinkMode_Ownership is missing a go doc

Could you make sure to add a godoc for the test, describing what it does and what it's for? Thanks :D

I also need to run this by @schavis to make sure there are no outstanding requested changes.

VioletHynes avatar May 27 '24 19:05 VioletHynes

Hi @VioletHynes - Thanks for the review. I just added the godoc for the test.

clwluvw avatar May 27 '24 19:05 clwluvw

Thanks! It's a holiday in some parts of the world today and I'll need to confirm with Sarah before I merge this, but I hope to get this merged soon this week :)

VioletHynes avatar May 27 '24 19:05 VioletHynes