Vincent Rouvreau

Results 100 comments of Vincent Rouvreau

I would like to try [this approach](https://github.com/VincentRouvreau/onetbb_cmake_fetch_content/blob/62576675c0ed52ef1809425f0c77d9d2fd39b9e8/CMakeLists.txt#L10-L19) that looks nice and modern to me. This involves cmake 3.11, but this version is already 4 years old, so it should be...

Thanks for the feedback. What I like with cmake fetch content feature, is that we can control which onetbb version we are using (direct in the cmake code, and no...

Redirection is not practical for our use cases (CI, https://gudhi.github.io/ , ...). We will keep relative links in our documentations.

I think we can close this issue thanks to https://github.com/cython/cython/issues/4312

> Did you check manually on an example (without duplicated points) that it gives exactly the same filtration as before? Ok if it does. Yes, the returned simplex trees are...

If you could render the notebook with https://github.com/GUDHI/gudhi-devel/pull/402 that would be nice too

ReviewNB has been installed on this project

cf. also https://gist.github.com/danieldogeanu/739f88ea5312aaa23180e162e3ae89ab

> Out of curiosity, does updating these mean that doxygen 1.9.5 is the new minimum version to build the doc, or is it compatible with older versions? This is what...

cf. https://github.com/GUDHI/gudhi-devel/commit/47e72c7250bff568735df829a40bcbea0a48f7c2