TDA-tutorial icon indicating copy to clipboard operation
TDA-tutorial copied to clipboard

AlphaDTMFiltration was failing with duplicated points

Open VincentRouvreau opened this issue 11 months ago • 3 comments

Ordering changes in 3d is no longer the behaviour

Fix #72

VincentRouvreau avatar Mar 01 '24 15:03 VincentRouvreau

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Did you check manually on an example (without duplicated points) that it gives exactly the same filtration as before? Ok if it does.

mglisse avatar Mar 01 '24 18:03 mglisse

Did you check manually on an example (without duplicated points) that it gives exactly the same filtration as before? Ok if it does.

Yes, the returned simplex trees are the same for AlphaDTMFiltration() if Y = X or Y = np.array([alpha_complex.get_point(i) for i in range(N_tot)])

VincentRouvreau avatar Mar 04 '24 07:03 VincentRouvreau