Vincent Langlet

Results 506 comments of Vincent Langlet

The stub was introduced by @craigfrancis in https://github.com/phpstan/phpstan-doctrine/pull/324 And this doesn't seems to be deprecated https://github.com/doctrine/orm/blob/0aa45dd607100182294d31dee42b89338773f87e/lib/Doctrine/ORM/Query/Expr.php#L638-L650 But there is a conditional return type: ``` @return ($val is literal-string ? ($x...

> The failing "mod function error" test should be unrelated to my changes. Yes, it's fixed in https://github.com/phpstan/phpstan-doctrine/pull/405 > There is no need to change the conditional return type, as...

Solved by https://github.com/php-enqueue/enqueue-dev/pull/1311 and release in 0.10.20

Friendly ping, Do you have tome to review this bugfix @julienfalque @keradus ?

Friendly ping, Do you have tome to review this feature @julienfalque @keradus ?

Would you have time to take a look/review this, @julienfalque @keradus ? Thanks a lot !

> For scalar type values it wraps the value into an array - inconsistent with casting an array, array is not wrapped again. I often see the following method ```...

The phpdoc is asking for string or string[]. If you are passing null or an object you already have an error from phpstan-core. You also can use string|array as a...

> @jordisala1991 could you give your approval again pleases 🙏 He's really busy atm ; and the approval will not really help moving this PR forward. I think you just...