Piyush Sharma
Piyush Sharma
I have handled the case of `draw_grid = False` and `draw_grid = None` separately. Specifically when `draw_grid = None` , I have refrained from changing the value of `visible`.
I have added the changelog, reorganized the patch, and included the regression test as requested.(I think I'll need more time to properly write the test )
Yes, will do I thought dividing the commits into smaller parts was a good practice, but I'll make sure to test my fix locally first before pushing them out together.
I understand , appreciate your guidance!
pre-commit.ci autofix
@neutrinoceros, would you mind taking a look at the recent changes? Thank you!
Thank you for guiding me through the process. Apologies for multiple commits.
I think if we specifically pass the parameter of `delim = '.'` , when we call the function `slugify` as `slugify('a.b.c.fits' , delim='.')` , we will get the desired result...
So should I remove my fix in `net.py` and remove the periods from the list that `slugify()` function replaces?
Sure, I'll investigate the root cause