Vibhav Sharma
Vibhav Sharma
> K its coming along nicely. Some nits surrounding coding style that we can go over. The biggest issues I see are: > > 1. The construction of the adjacency...
> Also just for edification, node1/node2 in the channel are just the lexicographical ordering of the identifiers. When I first starting learning this stuff I thought node1 was the opener...
> K its coming along nicely. Some nits surrounding coding style that we can go over. The biggest issues I see are: > > 1. The construction of the adjacency...
> > For Heap optimization, I found this package related to priority queues we can import that and workaround with it or should I build it from scratch? > >...
> min-heap looks good with a couple minors. If you want to split that into a separate PR and add tests we can merge it in. > > I still...
> Thank you for the PR, this will speed up chain rescans considerably! > > Great work so far, looks pretty good. My feedback mostly consists of style feedback, the...
> PR seems to be abandoned, submitting empty review to remove it from my "reviews requested" list. Recently solved a few test-coverage issues while implementing generic functions, and will be...