Velenir comments

Results 6 comments of


                                            Velenir

Empty coverage directory, no errors

If running `istanbul` inside `test` directory works, then ``` shell istanbul cover --root test _mocha ``` in parent directory should probably work.

Add build option for es modules

Does `rollup` implement tree shaking? Then maybe it can remove something in production.

Add build option for es modules

You're right. At best it could get rid of `utilities/getStateName`.

Reducer is not a function (within state tree)

Can one of the reducers you are combining (`meta, history, versions`) be not a function? They must be proper reducers of `function(state, action)` kind.

Create CONTRIBUTING.md

@W3stside what matters is that doc/md files end up on master, like `ADD_TOKEN_REQUEST_TEMPLATE.md` was merged to master first

Other routes are not fetched when targeting the api/prices

Are you passing `options.otherExchangePrices: true` to `SDK.getRate` call? ```ts const priceRoute = await paraSwap.getRate({ srcToken: ETH, destToken: DAI, amount: srcAmount, userAddress: senderAddress, side: SwapSide.SELL, options: { otherExchangePrices: true, }, });...