Vitalii Kryvenko

Results 283 comments of Vitalii Kryvenko

> compatibility with other not yet implemented features - what are these? You can see all the features planned in the issues in this repo. I don't think there are...

> 2*8 is just 1024, no so big number. just limit number of groups and it becomes constant. Note that the documentation in `const-typed-builder` mentions that the `N` in `2...

> While could separate stages, one is just assemble one big graph, and than traverse it streaming into TokensStreams, never concat. Several stages. Yeah, I understand that it's possible to...

> Could this be implemented by calling cfg_attr directly from duplicate, such that it can return an empty string when the cfg is false? There is no official stable API...

I just noticed how much context that discussion lacks. I recommend you to just take a look at this code [comment/macro here](https://github.com/elastio/bon/blob/3217b4b0349f03f0b2a5853310f420c5b8b005a7/bon/src/private/mod.rs#L85-L188) instead. The idea is that when the proc...

I didn't face this in a real use case, I just wondered how this is implemented in `tracing_loki`, and tested this, because I initially wanted to make my app run...

I tried using `Span::source_text()` to get the original source code of the default expression, but it always returns the span of the first token instead. The `span()` implementation of `syn::Expr`...

@angelorendina you mentioned in https://github.com/elastio/bon/issues/149#issuecomment-2523194682 that you got `getter(mut)` working. Although, I'd expect that to be difficult to do because `mut` is a keyword, and [`darling`](https://docs.rs/darling/latest/darling/) doesn't support parsing keywords...

Yeah, `getter_mut` is what I was expecting to see, since that would not fall into the `darling` parsing limitation trap. Just a headsup, I have a draft PR, that I'm...

I'm revisiting the getters design for `start_fn` members and `self` receiver of methods. I think we can avoid providing getters for them, and make those available as regular private fields...