Matvei Smirnov

Results 7 comments of Matvei Smirnov

Your current commit does not comply with the project's commit formatting rules (at least in terms of name length) https://github.com/Desbordante/desbordante-core/wiki/Development%E2%80%90General#%D0%BE%D1%84%D0%BE%D1%80%D0%BC%D0%BB%D0%B5%D0%BD%D0%B8%D0%B5-%D0%BA%D0%BE%D0%BC%D0%BC%D0%B8%D1%82%D0%BE%D0%B2

Perhaps after this PR it would also make sense to enable the building of packages for manylinux arm64, as many people have requested this (mainly macOS users who built the...

Since it is not very clear from the force push, I just swapped the include(cpm-cmake) and the cache variable setting, because the variable is used inside the include I also...

I mostly just passed by; I've been subscribed to PR since the very beginning. I'd like to point out that there are no "feat" or similar prefixes for commits according...

> Bump minimum CMake version and remove workarounds not minimum: -> Remove maximum CMake version and workarounds ?

> Isn't the alternative simply setting `included_content_layers`? see the docs page at: https://app.dosu.dev/097760a8-135e-4789-8234-90c8837d7f1c/documents/e596ee79-fc7f-43a4-90e2-74891e0cf12f HybridChunker doesn't seem to have such an option, and that's my case. And it's probably a conceptually...

> Then I think it is better to make add the option to the `HybridChunker`. It might be more generic, and it will apply to all document types. These options...