Varun Arora

Results 12 comments of Varun Arora

I also get similar error when I use the `auto` keyword in C++ ![image](https://user-images.githubusercontent.com/56734311/173567479-d4812262-cdd5-4ab7-9368-5030847cb16b.png)

I have created something like this locally - It has just the "Resend Receipt" button added on right side as suggested by @matkatmusic . Creating PR for same if this...

Hi @Devwill2 , I saw you were working on table based implementation which is why I started with drawer based and pasted screenshot above of implementation and PR creation before...

Created PR - https://github.com/antiwork/gumroad/pull/1779 Few questions - - Is there any desired place to put the Additional text? My PR puts it in headers of receipt view - Do we...

Hi @ershad , I see multiple specs failing due to `presigned_url` not being present for minio mocked AWS S3 objects. Since there is `minio_presigned_url` method in `SignedUrlHelper` module, I am...

@ershad can you please review this 🙏🏻

I have implemented something like below locally for mobile version - ### Before *** ## After ### 1 ### 2 ### 3 ### 4 ### 5 If this looks good...

Note - most specs in https://github.com/antiwork/gumroad/pull/1773 failed as they have `presigned_url` missing in them for s3 double locally. When minio mode is ON, the product code called `SignedUrlHelper#minio_presigned_url` which asks...

For the specs modified for other sidekiq jobs to use `NotificationWorker` instead of `SlackMessageWorker` the specs are passing locally as per below screenshots -

@binary-koan please review this and consider draft PR https://github.com/antiwork/gumroad/pull/2170 for context. This PR additionally makes changes for `NotificationWorker` to be used instead of `SlackMessageWorker` to have easier migration. I think...