Markos Girgis

Hello, I've been reading your Upvote Post useCase and i came across domain Services. My question is since they belong to the domain Layer, and Use Cases use their concrete...

I should get an error that the variable amount is not defined but i don't ```bl // Structs and DTOs... DomainService ReconciliationDomainService(reconciliationService: ReconciliationServicePort) { public reconcile(ledgerFinancialDocument: FinancialDocumentEntity, externalFinancialDocument: FinancialDocumentEntity): (OK(ReconciliationReportEntity),Errors(...

Set in tsconfig.json and tsconfig.base.json ```json "strictNullChecks": true, ``` Then we should also aim for `strict: true` It's bad practice to have it disabled and it can result in many...

BL Example ``` DomainError AccountIsBlockedError(accountId:string, accountStatus: AccountStatusVO) { message: `Account ${accountId} is ${accountStatus.status}. Please contact support.`, errorId: 'DRIVER_ACCOUNT_IS_BLOCKED' } ``` TS Output ```ts import { Domain } from '@bitloops/bl-boilerplate-core'; import...

The transpiled integration event uses `[key:string]: any` and as a result is not type safe. We should probably use a generic type (dynamic for each version) to make the payload...

Extend service port documentation with an example. One example based on the Todo could be: ```bl Struct SendEmailRequest { string origin; string destination; string content; } ServicePort EmailServicePort { send(email:...

Apollo v3 has become deprecated, with end-of-life scheduled for 22 October 2023. https://www.apollographql.com/docs/apollo-server/previous-versions/ Should update the dependency in boilerplate-graphql package to v4, and check that the generated code works(server, resolvers...

Reverse then and else body in domain if checks

1

### Subject of the issue Change if checks inside useCase's execute method body. ### Expected behaviour ### Actual behaviour  ### Suggested solutions? Expression should be reversed, and then-else bodies...