Max Gautier
Max Gautier
Is this still relevant after #11598 ?
Only on the first control-plane, nowhere else ?
This looks like a consequence from #7821 if I believe https://github.com/kubernetes/kubernetes/issues/127316#issuecomment-2354195820 => TL;DR violating version skew by upgrading kubelet first (instead of kube-apiserver)
That would be better addressed by a "is boolean" test in the validation tasks.
> But I am not opposed to trying. I would suggest to start really simple: select a single form of the keyword, and expect it to be on a separated...
/ok-to-test
> The recommendation survives under sig-architecture [here](https://github.com/kubernetes/community/blob/master/sig-architecture/naming/recommendations/001-master-control-plane.md), but I am not sure how to refer to this in a commit message. Putting that link into the commit message is perfectly...
Yeah it's fine. I usually do stuff like this : `group_names | intersect([] | length != 0` but your way is perfectly fine as well, and certainly better than the...
I'm fine with the content. Can you reformat your commit message though ? Not strictly respecting git recommended title length is fine, but you should still separate the tiltle of...
@yankay @mzaian I'm fine with putting this in 2.26 if you want, but it's a rather large change, do you prefer to defer until after the release ?