Max Gautier
Max Gautier
I have done quite a bit of refactoring of bootstrap-os some time ago, so it's possible the requirements is gone without we noticing. Re-reading the bootstap role, I don't why...
Actually, this check if for avoiding doing stuff which require that bootstrap-os has been run before, and it's only needed once (because all other invocation of kubespray-defaults are afterwards, and...
Can you properly separate the title of your commit from the message please ? The splitted phrase between the title and the commit body makes for a pretty bad experience...
/approve /lgtm
/retest-failed
/retest-failed
/ok-to-test This would need a proper release note
Another thing to consider here : the change is only necessary when changing cri_o runtime, which should not be happening very frequently. However, the cost (stopping kubelet , removing containers)...
I'll try to take a look next week