ValuedMammal

Improve fee sniping deterrence [BIP326]

2

### Description First attempt at bip326 for reference: [BIP326](https://github.com/bitcoin/bips/blob/master/bip-0326.mediawiki) [Bitcoin Core](https://github.com/bitcoin/bitcoin/blob/44d8b13c81e5276eb610c99f227a4d090cc532f6/src/wallet/spend.cpp#L908) [Sparrow](https://github.com/sparrowwallet/drongo/commit/c9e57fad018750a150a563cd17c8872d7cda48f0) ### Notes to the reviewers ### Changelog notice ### Checklists #### All Submissions: * [x] I've signed all...

feat(chain): Add `verify_tx` for TxGraph

10

Reintroduce a way to verify a transaction. This adds a new feature to `bdk_chain` that uses feature `bitcoin/bitcoinconsensus`, and exposes the same through bdk wallet as `bdk_chain/bitcoinconsensus`. closes #1180 ###...

Migrate to bitcoin::FeeRate

9

### Description closes #1136 This follows a similar approach to #1141 namely to remove `FeeRate` from `bdk::types` and instead defer to the upstream implementation for all fee rates. The idea...

Remove extra taproot fields when finalizing PSBT

3

We currently allow removing `partial_sigs` from a finalized PSBT, which is relevant to non-taproot inputs, however taproot related PSBT fields were left in place despite the recommendation of BIP371 to...

[chain] Change tx_last_seen to `Option<u64>`

2

fixes #1446 fixes #1396 ### Notes to the reviewers ### Changelog notice ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution...

This PR does some cleanup of the `bdk_wallet` signer module most notably by removing the internal trait `ComputeSighash` and replacing old code for computing the sighash (for legacy and segwit...

ci: Pin clippy to rust 1.78.0

1

This PR pins clippy check in CI to the rust 1.78 toolchain, which prevents new lints in stable releases from interrupting the usual workflow. Because rust versions are released on...

Make Wallet require a change descriptor

6

All `Wallet` constructors are modified to require a change descriptor, where previously it was optional. Additionally we enforce uniqueness of the change descriptor to avoid ambiguity when deriving scripts and...

Have more code conventions and guidelines

4

Using rustfmt means we always agree on code formatting. If rustfmt allows it, then matters of code style can be left to personal preference. However we could benefit from defining...

To me the name 'vin' suggests a 'vector of transaction inputs', therefore the elements of the input vector cannot also be called a Vin, correct me if I'm wrong. Recommend:...