ValuedMammal
ValuedMammal
I do think our signing flow could be smarter - it would be worth keeping an issue open to think about.
@nondiremanuel This should be mostly resolved by #1216
This might actually be fixed in #1194
@evanlinjin I'm curious what you mean by esplora returns conflicting unconfirmed txs. The approach to use `SystemTime::now` seems reasonable, although I recall someone made a related comment that system time...
Rename `Psbt::get_utxo_for` -> `utxo_at_index` ? or `get_txout`
I'd also be fine with making this a note in CONTRIBUTING.md along with some additional code conventions and guidelines, in hopes that it sort of implements itself over time.
> ``` > cargo test --all --all-features > ... > failures: > > ---- test_bump_fee_add_input_change_dust stdout ---- > thread 'test_bump_fee_add_input_change_dust' panicked at crates/bdk/tests/wallet.rs:2109:33: > called `Result::unwrap()` on an `Err` value:...
The only thing I'm confused about (on my end) is why I see this when trying to build locally ```sh error[E0277]: the trait bound `bitcoin::bitcoin_hashes::sha256d::Hash: ThirtyTwoByteHash` is not satisfied -->...
@apoelstra Thanks for adding the extra context. BDK has a trait `ComputeSighash` where the associated type `Sighash` looks to be correct for each script context `Legacy`, `Segwitv0`, and `Tap`. I...
@LLFourn Thanks for the detailed explanation. It helped clarify for me why persisting descriptor data at the wallet level is perhaps not enough. I think this direction is well aligned...