ValueRaider comments

Results 898 comments of


                                            ValueRaider

stock.info.get("preMarketPrice") returning None, even tho the pre-market price exist on the website

My `fast_info` update didn't interfere with this particular key, so something must have changed in the data Yahoo returns.

stock.info.get("preMarketPrice") returning None, even tho the pre-market price exist on the website

@robertluisw Wrong, that ticker doesn't exist.

stock.info.get("preMarketPrice") returning None, even tho the pre-market price exist on the website

Note sure why I closed this. To be precise - yfinance isn't returning None, Python is, that's the behaviour of `get()` when key not present. The old yfinance simply scraped...

Add CONTRIBUTING.md to make the rules, procedures clearer to new contributors

Good idea, and I wasn't aware (I've created a discussion instead). If you still want to do then yes, greatly appreciated.

Fix multiday div-adjust ; Tidy adjust args

@paulmcq You can review code in "Files changed" tab -> click '+' button by code

Fix multiday div-adjust ; Tidy adjust args

I tagged review for discussion - should yfinance do this?

Fix multiday div-adjust ; Tidy adjust args

I could link the 'dividend adjustment fix' to argument `repair=True`. Which is the bulk of this PR.

Add timeout to session.get() in get_all_by_isin() function

Instead, can `get_all_by_isin` be refactored to use `YfData`? Is a singleton so easy. Feel free to reduce timeout, there's no particular reason for 30. Also can you target `dev` branch?...

Upgrades and downgrades dates on site are different than yfinance

Compare the query YF sends to Yahoo API vs what Yahoo website sends to API.

"DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated" in the yfinance.download function

Best solution might be modifying `_parse_user_dt` to return TZ-aware datetime instead of epoch. Avoids `utcfromtimestamp`. #1084