Valentin Kaisermayer

Results 138 comments of Valentin Kaisermayer

Although, Simscape uses velocity and angular velocity for its mechanical domains. In the example you show, I think you do not need to specify `s_rel0` for the spring. It should...

Have you tested simply adding `k, Ti, Td` as `@parameters` to: https://github.com/SciML/ModelingToolkitStandardLibrary.jl/blob/f8bdbb9f91eadcf274c54dfcd5df94f189ffbd15/src/Blocks/continuous.jl#L310 They will end up as default values in other blocks, but that should not be a problem anymore:...

For normal stuff (e.g. parameter must be positive,...) it might be easy to use such a system. But in this specific case the parameter is "misused" as an option as...

How could a relational check be done? e.g. `a

You mean somewhere like [here](https://github.com/SciML/ModelingToolkit.jl/blob/6b92d37c6f7cd57cb5d4036123f6e5787cc212a5/src/systems/diffeqs/abstractodesystem.jl#L614) ?

I have run `format(".")`, no idea why it still complains.

The PR does not even touch the file it complains about.

> Are you sure you are using JuliaFormater 1.0? v1.0.3