Dev Ojha

icon company UC Berkeley, @sikkatech icon location I'm researching STARKs, working on github.com/scipr-lab/libiop, and am a student at UC Berkeley. I am interested in scaling blockchains. I CTF w/ @sicesquad

Results 383 comments of Dev Ojha

Estimate swap

Wait this code completely changed since last review, this is so much code duplication and very different. I don't think this is something we should've merged

investigate(x/gamm/twap): Reconsider using fixed size unix time serialization to save space in db

unfortunately I think we do need to close unfortunately. The TWAP code is code frozen aside from bug fixes, and this would require a state migration post-inclusion that seems not...

e2e testing should clear existing containers automatically

I've had this issue locally with containers not getting cleared, and having background osmosisd eat all system CPU for days

x/lockup: Ensure events are emitted and tests added

See PR discussion

amino encoding not enabled for tokenfactory

@pyramation do we have a setup so you can easily test if this now works with a local network?

amino encoding not enabled for tokenfactory

Fixed in v12

modify pool-incentives submit proposal cli

Sorry, I'm actually generally confused about whats going on in these governance proposal routing. My understanding is that in the today code, replace incentives proposal works on mainnet. Looking into...

modify pool-incentives submit proposal cli

(this is also needlessly complex, and we should simplify it)

Turn off all markdown lints by default, make explicit whitelist

I personally only find URL lints, and codeblocks should have language specified useful. Not sure what lints others find useful

feat(twap): historic pruning

We should remove ``` //nolint:unused,deadcode ``` right above ``` //nolint:unused,deadcode func (k Keeper) deleteHistoricalRecord(ctx sdk.Context, twap types.TwapRecord) { ```