Dev Ojha
Dev Ojha
Figuring out a solution here is also probably quite helpful for FFTs, since we shouldn't expect to achieve a truly linear relation between number of cores and time taken to...
Q1: Sparse polynomials in Arkworks are generally used for handling degree d polynomials that have a constant number of terms or `log(d)` terms. As far as I know, we don't...
FWIW I think mersenne prime field extensions are the future of STARKs =p. The arithmetic is so much faster! The quadratic extension field used in FourQ has a two adicity...
Per my recollection, the FFT algorithm should be identical. There should at most be something weird in creating the FFT domain. I think `sqrt` would need a custom implementation for...
Thanks for working on adapting these great changes to arkworks and upstreaming them! I'd like to ideally split this PR into many smaller PR's for easier review, would you like...
Ah sorry, didn't see the comment regarding not being willing to split up this PR. Is it fine if Pratyush and I go through and split up this into smaller...
Something I'd find helpful is moving `f_bench!` macro from curve-benches to algebra, and including some potentially redundant benchmarks for the test fields in `algebra`. Also maybe commenting out such a...
Would you like more reviews on this PR? If so, could there be a short description written up for what its doing? Happy to review then
Accidentally just reviewed the last few commits lol
AFAIU, the correctness guarantees of that function as written require it to be executed sequentially. Theres a couple things I'd like to understand: 1) How many constraints are there vs...