Vincent Wong comments

Repositories
Issues
Comments

Results 5 comments of


                                            Vincent Wong

Change all private methods on ManagedCustomElement subclasses to #private

Hi, I'm interested on working on this issue. Just to clarify, do you want to convert just the methods, or both the methods and properties?

Change all private methods on ManagedCustomElement subclasses to #private

Definitely agree with that first point there. Are there any particular areas that I could help with in terms of test coverage?

Cubes created from FaceletCube::from(faces) are invalid

Yes, you're completely right about this. Thank you for spotting this. I'll admit this is a bit of bad API moment. I think my original intention was to only have...

Refactor GeoCube with unsigned integers

Agree, will work on making these changes.

Scramble parser should return Result

Agree, will make change.