Universal_Robots_ROS_Driver icon indicating copy to clipboard operation
Universal_Robots_ROS_Driver copied to clipboard
verified publisher icon UniversalRobots

set receive timeout after connecting the client

Open steffen-roperobotics opened this issue 2 years ago • 4 comments

The dashboard client connect function resets the receive timeout to 1 s. To avoid that the receive timeout is reset the setReceiveTimeout call is moved to after the client is connected.

steffen-roperobotics avatar Dec 16 '22 09:12 steffen-roperobotics

Looks like you are right. Thanks for spotting this and providing the fix as a PR!

fmauch avatar Jan 03 '23 08:01 fmauch

Before merging I'd like to test this on a real hardware. I might have never switched installations using the dashboard client before. If a higher timeout is needed in order to switch installations, we should probably also change the default value.

fmauch avatar Jan 03 '23 08:01 fmauch

This PR hasn't made any progress for quite some time and will be closed soon. Please comment if it is still relevant.

github-actions[bot] avatar Jun 25 '23 22:06 github-actions[bot]

Yes, this is still relevant. I should test and merge this!

fmauch avatar Jun 26 '23 06:06 fmauch