Universal_Robots_ROS2_Driver icon indicating copy to clipboard operation
Universal_Robots_ROS2_Driver copied to clipboard

scheduled binary builds are not running on expected branches?

Open fmauch opened this issue 3 years ago • 2 comments

I just tried to build a new workspace on ROS foxy using the binary-build method, so only with ros2_control_demos, Universal_Robots_Client_Library, Universal_Robots_ROS2_Driver, ur_msgs inside my workspace and it failed.

One outcome of this is #200 and the other one is that I noticed, while the README shows a green badge for the foxy binary build, the workflow history doesn't look that good.

I am assuming, that this is not intentional. Unfortunately, running scheduled builds on branches isn't as straight-forward as it is with push/PR triggers. See also this post for details. However, modifying the checkout job directly as suggested there, would probably destroy running the workflow properly on PRs. With that, one would probably need a separate workflow file for the scheduled build...

fmauch avatar Oct 12 '21 07:10 fmauch

@fmauch Thank you for the heads up! CI workflow definitely needs more attention.

livanov93 avatar Oct 14 '21 14:10 livanov93

A lot changed since this issue was originally posted. We're currently putting in a lot of effort making all steps green. Once this is done, we can re-check whether everything is linked inside the READMEs as expected.

fmauch avatar May 06 '22 07:05 fmauch

This is done by now.

fmauch avatar Oct 11 '22 06:10 fmauch