ensure latched qos in gpio_controller is reliable
in case a user overrides the system default qos settings, the latched topics of gpio controller (robot_mode, safety_mode, etc) will be incompatible with a latched topic subscriber (transient local and reliable). this change ensures that gpio controller's latched topics are reliable.
Thank you for the contribution. I can see that setting reliability to "reliable" might be a valid option. Your main concern is that since we publish new data only on state changes, users might miss messages if they set their system default to "best_effort", right?
that's right, as a subscriber i would want to guarantee i can receive the changes. and since a "reliable" publisher is compatible with "best_effort" subscriptions, this would support all subscribers
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 15.24%. Comparing base (1b121b7) to head (144a71c).
:warning: Report is 527 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1594 +/- ##
==========================================
+ Coverage 3.59% 15.24% +11.65%
==========================================
Files 13 34 +21
Lines 947 3897 +2950
Branches 152 469 +317
==========================================
+ Hits 34 594 +560
- Misses 843 3286 +2443
+ Partials 70 17 -53
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 15.24% <100.00%> (+11.65%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.