Universal_Robots_ROS2_Driver icon indicating copy to clipboard operation
Universal_Robots_ROS2_Driver copied to clipboard

Launch arguments support bool instead of string types only

Open henningkayser opened this issue 6 months ago • 2 comments

The priorliy used string comparison would not work when passing proper bool types when including the launch file. This fix allows using both string and bool values.

henningkayser avatar Sep 04 '25 11:09 henningkayser

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 5.37%. Comparing base (1b121b7) to head (a216319). :warning: Report is 479 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1484      +/-   ##
========================================
+ Coverage   3.59%   5.37%   +1.78%     
========================================
  Files         13      33      +20     
  Lines        947    3239    +2292     
  Branches     152     391     +239     
========================================
+ Hits          34     174     +140     
- Misses       843    3063    +2220     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.37% <ø> (+1.78%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 04 '25 12:09 codecov[bot]

Hm, Kilted should be green except for binary/main. I'll check why it is not with this PR.

urfeex avatar Sep 08 '25 10:09 urfeex