ml-agents icon indicating copy to clipboard operation
ml-agents copied to clipboard

Remove numpy np.bool deprecation notice

Open stepjam opened this issue 3 years ago • 1 comments

Proposed change(s)

Removes the numpy deprecation notice regarding np.bool. Here we instead use bool.

/usr/local/lib/python3.8/dist-packages/mlagents_envs/rpc_utils.py:376: DeprecationWarning: `np.bool` is a deprecated alias for the builtin `bool`. To silence this warning, use `bool` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.bool_` here.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

N/A

Types of change(s)

  • [x] Bug fix
  • [ ] New feature
  • [ ] Code refactor
  • [ ] Breaking change
  • [ ] Documentation update
  • [ ] Other (please describe)

Checklist

N/A (removes deprecation)

  • [ ] Added tests that prove my fix is effective or that my feature works
  • [ ] Updated the changelog (if applicable)
  • [ ] Updated the documentation (if applicable)
  • [ ] Updated the migration guide (if applicable)

Other comments

stepjam avatar Oct 04 '22 17:10 stepjam

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 04 '22 17:10 CLAassistant

Closing: the deprecation fix was merged in as part of https://github.com/Unity-Technologies/ml-agents/commit/f9b7399338ec164ac5447f634b9a9af04538467e .

Thanks for your contributions!

alex-mccarthy-unity avatar Mar 14 '24 06:03 alex-mccarthy-unity