UncannyFish

Results 5 comments of UncannyFish

So I found at least 3 errors in this code: https://github.com/mvdevs/jk2mv/blob/fc18d906b8684a2546e99bbced59806e8b62d262/src/renderer/tr_font.cpp#L867-L880 1. `while` loop not checking for exceeding `iCharLimit` 2. `i += 2` can jump over `\0` in `psText`, so...

Thank you for such an in-depth response. For now I just disabled mv_coloredTextShadows in my local build, so VS 2022 can stop throwing exceptions at me.

I can't find find why `_off` stripping would be useful. I will look into it after some sleep. I haven't heard about grip, I will test it too.

I tested force grip. Looks like it was fixed too with this new table. Previously it was offsetting like pull/push.

Here is screenshots before fix. JK2 Kyle ![shot0002](https://user-images.githubusercontent.com/64485842/177346898-959352a9-ecc1-4a01-ac4b-cef58e9a929a.jpg) JKA Kyle ![shot0003](https://user-images.githubusercontent.com/64485842/177346918-e6dfe5fc-db9f-4241-a3e5-c64791320f10.jpg) After applying fix both Kyles look like on screenshot 1.