Unbinilium

Results 8 comments of Unbinilium

> That's nice! I will work on this on the weekend. The option name `gpg_signingkey` is probably better. Yeah, I agree and you choose the variable name for the api...

> We are using following snippet to dedupe `` tag: > > https://github.com/vuepress/vuepress-next/blob/33c9a2145eeaf53429f2ae784e393074d1a9edd5/packages/%40vuepress/shared/src/utils/resolveHeadIdentifier.ts#L11-L14 > > But I think that supporting multiple `` tags should be another issue. https://github.com/vuepress/vuepress-next/blob/b0a9815c9eeaa2ba623cc1a153139e85397d450e/packages/%40vuepress/shared/src/utils/resolveHeadIdentifier.ts#L11-L14 It seems...

> The problem about site data could be handled in this PR. If you are not familiar with that, I'll update it later. I'm not familiar with that and now...

> Another point: > > Currently in this PR, we are using `--c-bg` and `--c-brand` as the theme color. But users could set different theme color in `head` config Do...

Thanks, it works as expected after fix a logic typo in commit https://github.com/vuepress/vuepress-next/pull/218/commits/5bd549845d8758c668b99d5cedace284aee96468. But has another problem you mentioned before: > There's another problem. > > Meta tags set in...

Considering that simply changing the meta tag of `theme-color` in `siteData` would cause `themeColorHeadContent` not find the original theme-color after repeatedly switching dark mode, and adding a temporary variable to...

> Sounds good to me. > > The color should sync with css vars PR in #218, but still some problem need help, see it in PR note.

I noticed that the `reinitialize()` function was commented like this in v8.9.2: ```js function reinitialize() { // `mermaidAPI.reinitialize: v${pkg.version}`, // JSON.stringify(options), // options.themeVariables.primaryColor; // // if (options.theme && theme[options.theme]) {...