Ulises Gascón
Ulises Gascón
Well... This can be more tricky than it seems ([ref](https://github.com/expressjs/multer/issues/1305)): So far seems like we had break semver compatibility in [email protected] due a patch for CVE-2022-24434: > Multer 1.x is...
This sounds great! Let use this issue as a backlog. I will create a branch `v2` where we can land PRs
Branch created: https://github.com/expressjs/session/tree/v2
@bjohansebas seems like we have already a milestone https://github.com/expressjs/session/milestone/1 for v2.x . Maybe we can rescue some ideas from there and use re-use the milestone. WDYT?
I set aside some time this week to work on the repo and review/merge the current PRs. I'm very happy to see this level of engagement recently! ❤️
As we support [email protected] the `^` for dependencies is not supported ([ref](https://github.com/expressjs/session/actions/runs/15094481112/job/42427366620?pr=1060)): ``` npm ERR! Error: No compatible version found: side-channel@'^1.0.6' npm ERR! Valid install targets: npm ERR! ["1.0.1","1.0.2","1.0.3","1.0.4","1.0.5","1.0.6","1.1.0"] npm...
I will suggest to include tests, [here](https://github.com/lodash/lodash/blob/main/test/inRange.spec.js) you can find an example from the `inRange()` function ([docs](https://lodash.com/docs/4.17.15#inRange)).
This is bug as we forgot to update the `engine` field (also by policy the field change is consided a semver-major), but optional chaining was included as we dropped support...
Any news on this?