UkoeHB
UkoeHB
Not sure why CI is failing. @jeffro256 any ideas?
@jeffro256 updated, sorry for the delay.
MCIP #12 should be listed in `Rationale and Alternatives`.
> The other thing that is confusing to me is, the MCIP really means that consensus gets to decide the tombstone block arbitrarily and not the client, so these transactions...
> Maybe consensus can tell the client the invented tombstone block when they submit it? So that the client can still know when it is dead Idk if this is...
Why put the ack delay in the ack packet, and not as a config? This makes ack packets bigger and adds risk of malicious effects. It also breaks from the...
What about adding the config to `ConnectionConfig`? Users are already expected to use the same channels, so including ack delay wouldn't be too unusual. You can make it `Option` and...
How about instead of `Duration` you store a `u16` for the number of milliseconds delayed? EDIT: Oh I see you're doing a `u32` for `us`. Is that level of precision...
> But I would probably remove channel_id from ChannelConfig and automatically assign it based on the index. This way we ensure that channels have sequenced IDs. That would be a...
@vtnerd pay-for-RPC should already be removed: https://github.com/monero-project/monero/pull/8724