move_basic icon indicating copy to clipboard operation
move_basic copied to clipboard

RootRework: General Refactor and Rewrite

Open MoffKalast opened this issue 2 years ago • 2 comments

After #103 is done and we've got move_smooth to work on, we should do a general rewrite of the node to clean up the code and sort out or at least somewhat address the following issues and add required features:

  • [ ] reducing fishtailing
  • [ ] running away from/missing goals
  • [ ] implementing a 2D PID system

MoffKalast avatar Mar 22 '22 21:03 MoffKalast

Why do you want to implement 2D PID system? I assume it's lateral and linear control but that's already done. I forgot but I think we are using Stanley lateral controller and linear is just max acceleration->max speed-> max decceleration.

dorkamotorka avatar Mar 23 '22 07:03 dorkamotorka

I'm not sure, I wasn't directly involved with that discussion at the time but that's what I last remember being the plan. We should probably have a meeting to get on the same page about it.

MoffKalast avatar Mar 23 '22 14:03 MoffKalast