Tyler Brinkley

Is there an error or does it return `false` when `true` is expected? What is the base type of the `ObjectModification` enum, `int`, `byte`, etc? What version of `Enums.NET` are...

`EnumFormat`s support parsing and outputting. If they were allowed to support multiple values for parsing Enums.NET would not know what version for outputting with the `AsString` method. I'd suggest you...

That's an interesting edge case I never considered. I'd imagine the fact that `System.Enum` supported that case was by happenstance and not by design and I wouldn't trust that it...

I anxiously await this being merged to add portable pdb support. Currently using a build from this branch to support my current scenario. Update: I'm able to create the pdb...

Hmm, could `ReferenceResolver` be added to `JsonReader` and `JsonWriter` instead which are both available to `JsonConverter`s?

It seems to me that `JsonReader`s and `JsonWriter`s are not used concurrently and thus would work well to expose the currently used `IReferenceResolver`. As such I've updated the pull request...

Hmm, maybe we could use a `JsonSerializerProxy` for each serialization call to pass to `JsonConverter`s whose `ReferenceResolver` property is specific to that serialization call? Then we wouldn't need to add...

I just implemented what I proposed above. It looks like a `JsonSerializerProxy` was already being passed to `JsonConverter`s so no changes needed there.

I just realized you baked your `DefaultReferenceResolver`'s state into `JsonSerializerInternalBase`'s `DefaultReferenceMappings` property. The only state that is not baked in is the reference count hence the creation of #1391. As...

Resolved merge conflicts