Tyler Ruckinger

Results 18 comments of Tyler Ruckinger

I think a "Notice" log level and a "Critical" log level would both be very nice to have. I would argue "Critical" in particular is a very necessary addition. I...

> Adding a log level is a breaking change. Breaking changes happen. The de-facto logging crate shouldn't hinder itself by refusing to make breaking changes. > The existing levels match...

I thought about this some more, and I think these are some things to consider regarding forbids_unsafe requirements: 1. cargo geiger appears to always ignore examples. An example can contain...

> would require building each binary in addition to the library To be honest I assumed they were being built already since they were included in the forbids unsafe requirements....

> Do you have an example where that happens? No, sorry I had the thought process of "it sees the binaries aren't forbidding unsafe code, therefore it must be building...

`u64::from_ne_bytes()` is available on 1.32 so it should be doable while keeping MSRV 1.32, unless there's something else that would be needed.

Consider looking here: https://github.com/rfru/vsc-prettify-symbols-mode/commit/99f856848d17da93958db83842652c21326a5a0a#diff-898332678664790ddb753092948f301d3b040f2eb965f7a289194c768115a985L162-R167 Disclaimer: I claim no actual understanding of this code, just saw this in the network graph.

Thanks. I'm starting to go through the code now. I am noticing some parts of the public API is unix specific (for example one of the error types contains a...

Hey, I'm still working on this, slowly making progress when I have time. I've gotten far enough that this code works in Windows. ```rust let mut ping = crate::spawn("ping 127.0.0.1",...

> Re: adding Command: would this be exposed also in APIs Yes, it would be exposed and therefore is a breaking change. I could make this not a breaking change...