Ty Overby
Ty Overby
After asking for the PR to be split up, I did the benchmarking which has me pretty confident that the change should instead be abandoned, so I don’t want anyone...
I suspect it’s the … args syntax, but I don’t know for sure.
I haven’t run this on any real applications because we aren’t easily able to pull in jsoo branches until wasm is merged. However, i think that microbenchmarks are sufficient to...
What is the purpose of the PR then? Did some user of Js_of_ocaml need the runtime javascript to be more “modern” for some reason? FWIW, I find the new style...
Js_of_ocaml does a fine job of dead-code elimination, but because expect-tests are enabled or disabled vis environment variable, you need to tell jsoo that the expect-test env var is always...
There's a lot of unexpected changes in this PR, I think you may need to rebase it?
Interestingly, on Safari Technology Preview, CAMLBOY runs just fine, but my program completely crashes the tab that it's in without even printing to the console
Fwiw, I’m not super worried about this issue, I just wanted to see if wasm_of_ocaml would work on other browsers. Feel free to resolve this issue by updating the documentation
Confirmed to be resolved in Safari Tech Preview as of `Release 221 (WebKit 20622.1.15.19.2)`. Not yet fixed in mainline Safari.
Thanks! I started playing around with `wasm-ctor-eval` and found that the first thing I hit was calling an imported [function for performing pointer equality testing](https://github.com/ocaml-wasm/wasm_of_ocaml/blob/main/runtime/wasm/runtime.js#L113), and I suspect that if...