Ty Overby

Results 123 comments of Ty Overby

Oh interesting; I didn't know about that parsing behavior! I'll admit I'm not super familiar with the cmarkit codebase yet; do you have an intuition for how best to solve...

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

> Am I missing something? no, this is a mistake on our part :( thanks for bringing it to our attention, we’ll try to fix this

> This issue can be closed when the feature flag for HTML is removed, and the HTML parser and formatter is publicly available. What is this feature flag? In addition...

We've been using https://github.com/mnxn/promise_jsoo for a few years now, and it's worked pretty well for us

Incr_dom hasn’t been tested with effect handlers yet, so I’m not surprised that there are issues. Could you describe the problem that you’re running into though?

Oh sorry, I see now that you said that the effect triggers an “unhandled” exception. Thats expected because Incr_dom.start just schedules stuff to happen on future frames and it returns...

I think that incr_dom would need custom logic in the event loop for effects to work

I don’t think the other PR was reviewed

A recent bugfix that prevents consuming data out of a connection that has already been upgraded. ```diff diff --git a/lib/server_connection.ml b/lib/server_connection.ml --- a/lib/server_connection.ml +++ b/lib/server_connection.ml @@ -273,7 +273,12 @@ let...