Will Usher

Results 129 comments of Will Usher

Thanks @Vecvec , I think this looks good! Maybe we can add an example showing the buffer path as well?

I think just having the `f32` buffer support is fine here, since the `x2`, `x3` versions could be treated as f32 by just aliasing them. I think this looks good,...

It sounds like `OIDN_DIR` is in your library path in that case, for that config it would make sense to make `OIDN_DIR` not be required. The build script could check...

I think so, I didn't find that issue when doing an initial search but I think the bug is the same

This should be possible to do with some modifications to the crate, maybe we can add a "packaged oidn" build mode. It would work similar to the runtime only support...

The downside is that I think this would add about 100MB to the crate (packaging all OIDN builds: https://github.com/RenderKit/oidn/releases/tag/v2.2.2 )

It looks like the CMake scripts expects the `VULKAN_SDK` path to not contain `x86_64` (https://github.com/Twinklebear/ChameleonRT/blob/master/backends/vulkan/cmake/FindVulkan.cmake#L76), so could you try setting: ``` export VULKAN_SDK=/opt/build/vulkansdk-linux-x86_64-1.3.283.0/ ``` and see if it's able to...

Have you tried other models besides this one? I wonder if it's completely black because the camera is inside the house, there's no ambient light term in the renderer so...