Manu Evans

Results 101 comments of Manu Evans

I agree with your view. And I also suggest the latter, but we can live with it as is for the moment I think. I do need the values array,...

For clarity, the reason I created E.Key0 == "Key0" is that if you use E.Key0 in your lua code instead of string literals, it will silently port to userdata when...

Is this blocked on anything in particular? Anything I can do to help?

I have more in the pipeline, but I need to get this sequence of patched through before I push more. The next set start building on top of this stuff,...

@aubade If you want to test my patches with your stuff? I'm only testing against my own environment. Also, I get the feeling it could do with more unittests if...

Probably best approach is to fork my repo, and then work against each of my feature branches individually. Then you can create PR to me, and that will flow through...

Let me know when you isolate the struct property issue. I've had good results in all my cases. I think I have a fix for the module thing in another...

I think the problem with your setters is that they don't return void. setters are supposed to return void... (no?) The others should be straight forward, I'll check it out...

Is it idiomatic? I've never seen it anywhere... why isn't that the standard? It's better to comment in the appropriate place, but it doesn't matter now.

> Most of all though, there needs to be tests. Yes, this would really help. > In the preliminary tests I wrote for this patch (why am I the one...