Pascal Obry
Pascal Obry
But maybe we cannot do better for master edit. Users using master are prepared for that. @jenshannoschwalm : Or do you have an idea to fix master edit?
> 1. @TurboGit suggested above simple code; the relative width/height of the selected crop area for me is not defined via the cw/ch parameters but by the difference (cw-cx) /...
@jenshannoschwalm : So at this stage what do you think? Is my simple patch ok for 5.4 and we tell that any edit with master will be possibly broken? Or...
> there are issues too with an image that was cropped **freehand** under 5.2.1. So we are doomed :( EDIT: And for freehand crop we don't have a way to...
> Would `darktable.gui->reset` be a better option? If you can fix this with this it would be better indeed as this is a common pattern already used in many places.
> So, if it's not a bugfix, do we want to merge it before or after the release? After the release.
I have been able to reproduce with an old edit. @jenshannoschwalm : Probably related to the last changes on crop module. Can you have a look?
@jenshannoschwalm : Yes, the picture was portrait in 3:2 aspect ratio. I tried to change position and/or change crop size and ends up with a square crop and sometime with...
No problem, here is a link https://drive.google.com/file/d/1p1Bv5c-rMTVokVrIVPJIhN6PyxTJDEB7/view?usp=sharing
@jenshannoschwalm : This bug is important enough to delay the creation of the tarball (that I should have done tonight) for the release.