Pascal Obry
Pascal Obry
@jenshannoschwalm : I see, the hack is frightening so close of the release. Ok to talk at 9pm. What is your timezone and DST (daylight saving time)? At the time...
I have tested this PR and the thumbs is like this: It is not as in 5.2.1 and not as in current master. I'm not sure now which crop is...
Reading the code the change in `modify_roi_out()` is frightening and I'm not sure this is good for the release. We really need to discuss that.
Signal or Element. Whatever is easier for you.
@jenshannoschwalm : Not sure you have my id on both. Maybe jitsi meet ? Just click: https://meet.jit.si/dt
@jenshannoschwalm : The link to the archive: https://drive.google.com/file/d/1p1Bv5c-rMTVokVrIVPJIhN6PyxTJDEB7/view?usp=sharing It also contains screen shot of the rendering of the thumbs in 5.2.1, in master and after edit (only expand/collapse crop). My...
> The old portrait example unfortunately has cx/cy at zero :-( How is that possible? I mean when I open the picture on 5.2.1 my crop area is properly kept...
This is what I have on 5.2.1 when hovering on crop in history: No zero there.
@jenshannoschwalm : Maybe you're looking at the master .xmp? The ones in the `xmp-5.2.1` directory don't have zero and those are the ones to migrate properly.
@jenshannoschwalm : What about this which seems to be working on the 2 samples I sent: ``` else if(old_version == 2) { const dt_iop_crop_params_t *o = (dt_iop_crop_params_t *)old_params; dt_iop_crop_params_t *n...