Tuomas Borman
Tuomas Borman
Closing for now
Do you have the latest versions? In addition to those NOTEs that you get, I get also NOTEs about roxygen See the latest workflow run https://github.com/microbiome/mia/actions/runs/8849563656/job/24301848155
@thpralas has checked this unifrac thing little bit
Yes, that's ok. As we have now more contributors, it is better to switch using the "assignees" field.
Little bit related to this same thing: also faith index implementation could be changed so that we use external package instead of our own implementation. Good thing about picante was...
I agree with this. We could have merge(MARGIN = "features") function; inside the function MARGIN could specify whether to run .merge_features or .merge_samples internal functions
`addTaxonomyTree()` and `taxonomyTree()` are calculating tree based on taxonomy info provided in `rowData`. This is misleading users because the calculated tree is not really a taxonomy tree. Taxonomy tree refers...
I would go then with `getHierarchyTree` --> explains quite well what is happening I think `add*` is quite convenient and we should not remove it. Rather we should focus on...
In the documetation, we could refer this as hierarchy tree and not taxonomy tree. The possibility for misunderstanding is not that big then anymore