Trung Bùi

> @TrungBui59 Thanks. Looks like your screenshot only covers the final summary of the failing e2e tests. Could you scroll up, find the verbose logs for each failing scenario, and...

> There are 3 ways of filling host gateway IP in nerdctl: config, command arg and env var. > > > > Finch should also support all of them for...

@ningziwen Sorry for not being responsive, I was busy with my intern work. I still dont know how to make it change the host-gateway-ip when the VM starts/restarts. I can...

@ningziwen Sorry for not being really responsive, I was busy with my intern work. I still dont know how to make it change the host-gateway-ip when the VM starts/restarts. I...

> @TrungBui59 Reading the code, it seems passing it [here](https://github.com/runfinch/finch/blob/fef6e772c28429ef14068702c1dfd8e9fec2dea1/cmd/finch/virtual_machine.go#L93) should work. Have you tried it? What is the error? @ningziwen The current approach is that I will pass the...

> > @TrungBui59 Reading the code, it seems passing it [here](https://github.com/runfinch/finch/blob/fef6e772c28429ef14068702c1dfd8e9fec2dea1/cmd/finch/virtual_machine.go#L93) should work. Have you tried it? What is the error? > > @ningziwen The current approach is that I...

> Could you add e2e tests? The host-gateway-ip in finch config is under e2e/vm? Similar to https://github.com/runfinch/finch/blob/main/e2e/vm/additional_disk_test.go > > The host-gateway-ip arg and env var can be added in common-tests...

@ningziwen sorry for the late response, I have finalized by adding unit tests and e2e tests

> One nit pick. Also need to fix the errors in CI. > > Others LGTM. > > Need a follow-up PR in https://github.com/runfinch/common-tests to test CLI flag and env...

> > > One nit pick. Also need to fix the errors in CI. > > > > Others LGTM. > > > > Need a follow-up PR in https://github.com/runfinch/common-tests...