Rich Trott

icon indicating an email [email protected]

icon location San Francisco, CA icon location I create software, rock operas, and pizzas. I am a member of the Node.js Technical Steering Committee and work for the University of California. he/him

Results 501 comments of Rich Trott

Incorrect cwd() inside subfolders of Windows directory symlinks or junctions

> As you can see, in Linux the symlink in `pwd` is _not_ resolved, whereas in Node it is resolved. `pwd` is similar to `cwd` but it is not the...

refactor: undefined check for tls_wrap

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/952/

refactor: undefined check for tls_wrap

I have a 100% wrong rate on benchmark predictions lately, but I'm going to guess that this one will be fine. Shouldn't be a hot path, I don't think?

dns: fix `uv_timer_start` usage

@nodejs/dns

inspect: fix pop undefined when array prototype pop deleted

Can we add a test for this? I think the perf hit might be worth it for the robustness in this case, although I wonder if @nodejs/util would agree or...

child_process: add an API to escape shell argument

/ping @nodejs/child_process @nodejs/tsc @devsnek See conversation in https://github.com/nodejs/node/issues/34840 for arguments for and against including this in core.

test: check inspector command Debugger.setInstrumentationBreakpoint

> It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I...

test: check inspector command Debugger.setInstrumentationBreakpoint

@nodejs/inspector

lib: the REPL should survive deletion of Array.prototype methods

Can/should we add a test that crashes the current REPL but not the REPL with these changes?

lib: the REPL should survive deletion of Array.prototype methods

I took the liberty of adding a test. Hope that's OK. (It's in a separate commit so it is easy to rebase out.)