node
node copied to clipboard
nodejs
test: check inspector command Debugger.setInstrumentationBreakpoint
Adds test case for inspector's method Debugger.setInstrumentationBreakpoint with beforeScriptExecution param.
Checklist
- [x]
make -j4 test(UNIX), orvcbuild test(Windows) passes - [x] tests and/or benchmarks are included
- [x] commit message follows commit guidelines
@BridgeAR It is a test for an issue https://github.com/nodejs/node/issues/31138. We can't merge this pull request until the issue is fixed because the test is broken. Sorry if such workflow is bad, we can simply reject the pull request and wait for the issue to be fixed, test is still referenced from it and can be found.
It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.
It is possible to add this test and mark it as failing in our status file. That way it would only fail in case this test passes. If I understood correct, this test is legit and it should pass while it fails at the moment. That way it's possible to just remove the test from our status file while fixing the issue.
If the test fails 100% of the time, probably best to put it in known_issues and then we can move it out to parallel (or wherever) when the fix is committed.
This is a quite old PR, I see it ties into #31138 is there any updates?
