Rich Trott

Results 435 comments of Rich Trott

Prior art: * TSC charter requires members to attend meetings or participate in votes to retain membership. * Window checked is 3 months. * Enforced by https://github.com/nodejs/node/blob/a698c49993050491c00d1127236d714c9e8ce2eb/.github/workflows/find-inactive-tsc.yml * Collaborators in...

One way to resolve this issue would be to retire our Jenkins-generated coverage and rely on https://app.codecov.io/gh/nodejs/node which is generated by GitHub Actions.

> One way to resolve this issue would be to retire our Jenkins-generated coverage and rely on https://app.codecov.io/gh/nodejs/node which is generated by GitHub Actions. Argh, although I guess that would...

Is the problem that an expectation of Node.js 14 is coded somewhere (maybe in an environment variable set by the job?) but running this on the master branch compiles Node.js...

Yeah, looks like `NODEJS_MAJOR_VERSION` in the Jenkins job parameters is set to 14. We won't need to bump this every release of Node.js, will we? Is that something releasers do...

> You'll probably need to work out how node-test-commit-windows-fanned is setting and passing `NODEJS_MAJOR_VERSION` to node-compile-windows. It looks like it's hardcoded in the configuration seen at https://ci.nodejs.org/view/All/job/node-test-commit-windows-coverage-daily/configure.

> /cc @Trott @addaleax I won't be able to travel during that time. Moreover, I've been suggesting a hiatus for Node.js core Code + Learn events, for various reasons. But...

@nodejs/tsc PTAL. Also, this would be good to at least mention, if not discuss, at the TSC meeting on Thursday.

> Tagging for TSC agenda. I think we should discuss in a TSC meeting to make sure there is consensus to ask for an exception versus any other alternative. I...

@nodejs/tsc Consider getting your opinion in early if you already have it: 👍 = relicense 😄 = exception 🎉 = I do not have an opinion on this and do...