L. Kärkkäinen
L. Kärkkäinen
Now it works much better than the old one. Clear and uberprecise detection in practice, and seems to be working in singing too. During testing I got one segfault but...
@Lord-Kamina See `Notes::powerFactor` that's the essence of vocal scoring. `MusicalScale` for conversions between Hz and note numbers. `Player::update` for the main vocal grading loop.
I didn't get a dump and couldn't get it to crash again.
This is still a work in progress. I'm developing the algorithm in Python, and what you see here is a port to C++ (curiously, the Python version runs faster). There...
It might take a very long time until I can pick this up again. If you don't mind keeping around a draft, feel free to keep it here. Possibly some...
This is also available for testing. IMO this has clearly better performance than either master or pitchdetector1 but YMMV because the algorithm is largely redesigned. If there is agreement that...
@Baklap4 Yes, this is intended to supersede the other PR. The new phase equation is included and levels are tuned in this as well. Also, if the other PR is...
> someone that can actually whistle to a song It was surprisingly easy to hit the notes on Hard difficulty. The pitch wave looks different too.
The pitch waves show high frequency, suggesting that something other than your singing (base frequency) is being detected. Could you check in practice screen visually which notes appear? Also check...
@ooshlablu I think you need to adjust mic volume in alsamixer, switch to capture volumes on the physical device of the mic(s). If your device supports that. Could you confirm...