L. Kärkkäinen

Results 252 comments of L. Kärkkäinen

Almost correct with this config. Apparently IPv6 remote_host would need to be bracketed but I don't know how to do that with Caddy yet. Also, would prefer a shorthand config...

Thanks for the quick and thoughtful replies. Caddy is indeed in a deep mess in trying to parse downstream headers. There would be no ambiguity though, because each type of...

Indeed, no downstream uses `Forwarded`, so parsing it is a lesser concern, and if Caddy can somehow produce correct the client IP of the mess we've got then simply adding...

Solved by config hackery. ```caddy (forwarded) { map {remote_host} {for} { ~^[0-9.]+$ for=${0} # IPv4 client address ~^[0-9A-Fa-f:.]+$ for="[${0}]" # IPv6 bracketed and quoted default for=unknown # Unix socket }...

> complexity of Forwarded I believe this is complete for sending them upstream as per option 1 below. > `client_ip` A good idea for option 2... Actually I thought `remote_host`...

Quite many tests run the server on some hardcoded port, so a bit of care might be needed to enable parallel tests.

Installing dependencies is also a big slowdown with the current CI. Perhaps that can be sped up somehow? Using a Docker image with everything preinstalled, for instance?

@iAndriy This is correct, the vast majority of time is consumed in pytest. Different platforms are run in parallel but it still takes long, and this is cumbersome when running...

I found quite many tests failing both on local MacOS and some versions of Linux. These were addressed in #2844 in case you want to dig up the diff or...

@ahopkins It has also been a problem as long as I can remember. Got bitten by it in my very first Sanic app, and I still often forget to include...