一笑 comments

Results 72 comments of


                                            一笑

`transform` plugin hooks is forbidden to be asynchronous

Because you are using the wrong type for the `transform` hook, its type is not `TransformHook`.

`transform` plugin hooks is forbidden to be asynchronous

Yeah, you are right, it is a documentation issue, reopened it.

`transform` plugin hooks is forbidden to be asynchronous

Yes, I think so.

Support new "using" keyword for disposable objects

For Rollup V3, we need to wait for acorn.js to support parsing `using`. But it's in stage 3 for JavaScript, I'm not sure the team of acorn.js will support it...

Cannot read properties of null (reading 'start')

I didn't encounter this issue on the `feat/use_items` branch either. Using Node.js 23.2 on a Mac M1 Pro.

Cannot read properties of null (reading 'start')

Can you check which version of `@rollup/rollup-darwin-arm64` is in your `node_modules` by running `npm list @rollup/rollup-darwin-arm64` locally?

Cannot read properties of null (reading 'start')

Alright, it's too weird.

Supporting multiple modules corresponding to the same id but with a different import attributes

For `this.getModuleInfo`, I think it can accept an object that includes `id` and `attributes`, and we construct `fullId` internally. For `this.load`, we can keep it as before, we just need...

Supporting multiple modules corresponding to the same id but with a different import attributes

> My feeling is that for consistency, I would rather adapt the signature of `this.load` to align with the proposed change for `this.getModuleInfo` so that the signature is > >...

Support import ... with {} syntax in the plugin pipeline

Yeah, This PR #5700 implements this.