Tycho Bokdam

Results 140 comments of Tycho Bokdam

For Apple pay the interface also says that `currencyCode` does not exist, but when trying to do a payment Safari throws `Unhandled Promise Rejection: TypeError: Member ApplePayPaymentRequest.currencyCode is required and...

Solved this by adding this to my app's theme: ``` @style/ThemeOverlay.AppCompat.Dark.ActionBar @style/CustomCastExpandedController ``` ``` @array/cast_expanded_controller_control_buttons ``` My arrays.xml: ``` @id/cast_button_type_closed_caption @id/cast_button_type_empty @id/cast_button_type_empty @id/cast_button_type_mute_toggle ``` Maybe this should also be documented...

@nenjamin2405 sorry no, i only used this lib on Android.

@victorhermes The first two parts are inside `styles.xml` and the second one is inside `arrays.xml`

Had a simular issue, this can be solved by marking the HTML as [escaped](https://formatjs.io/docs/core-concepts/icu-syntax/#quoting--escaping) Example: `Hello ''{name}''`

Hmm that is a good one, I indeed think that [`JSON.stringify`](https://github.com/TriPSs/conventional-changelog-action/blob/releases%2Fv3/src/version/json.js#L48) does not add an empty line. Maybe we can make it opt in/out.

Think we can also make it auto detect by checking if the last line of the file is empty.

I think this was always the case but in 3.14.1 we catch unhandled exceptions and markt he job failed.

`dont-pull` and `dont-push` are not valid optons? Could you try with `skip-git-pull`, this should prevent the initial pulling.

Could it be something you do in `.github/tools/changelog-config.js`? As the error happens directly after that?