[Question] remove newline in end of the version file by default?

[tyn1998]

Hi, @TriPSs, thanks for providing such a great action!

I have a question here: if it is true that CCA will remove newline in end of the version file by default? Please see https://github.com/opensumi/devtools/pull/4#discussion_r959542074.

My workflow is: https://github.com/opensumi/devtools/blob/d2984fc78f574bef7ad06188c1ef3ff9eee49efd/.github/workflows/release.yml#L20-L26

[TriPSs]

Hmm that is a good one, I indeed think that JSON.stringify does not add an empty line.

Maybe we can make it opt in/out.

[tyn1998]

That will be so nice!

In another case I use a pre-commit file to bump version manually, where the end of line is not affected because of this.

[ghost]

I agree with this issue. Removing the newline is breaking my CI.

package.json shouldn't be modified at all outside of the version bump.

[TriPSs]

Think we can also make it auto detect by checking if the last line of the file is empty.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.